Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
C code_review
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge requests 47
    • Merge requests 47
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Tanzeer Hossain
  • code_review
  • Merge requests
  • !54

Open
Created Oct 17, 2019 by Abdella Mohammed Albadani@fj0335
  • Report abuse
Report abuse

Updated main.cpp

  • Overview 5
  • Commits 1
  • Changes 1

lines 26-28:names here are rather vague case a case b case c what do these cases do? the programmer wouldn't know unless they went through the function code line 70: the assignment operator is used but we are comparing root with an empty value need to use == line 93: missing break statement; line 108: misleading comment, element is named to the find function line 152: Again were not assigning root to null, this will create a bug where the root is assigned to root after insertion, updated to comparison assignment line 170: indentation for if statements could be slightly better line 215: if statements would be better with brackets to avoid errors when programming

Edited Oct 17, 2019 by Abdella Mohammed Albadani
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: patch-1